compatibility between dorado and modkit
there's a compatibility issue between dorado v1.0+ and modkit v0.4-:
Yes, the modified base models in Dorado v1.0 require you to use either --modified-bases-threshold 0.0 whilst basecalling/modification calling or Modkit v0.5.0. The reason is that the false-positive rate in the latest models is quite a bit lower and the filter threshold may be estimated to be 1.0 (you could confirm this in the pileup logs). If the threshold is estimated to be 1.0, all of the modification calls will be filtered out. Modkit 0.5.0 has a shim to keep this from happening.
the pkgs in containers/debian-nanopore.def
are affected by this issue. specifically:
# Install modkit
cd /opt
mkdir modkit && cd modkit
wget https://github.com/nanoporetech/modkit/releases/download/v0.4.4/modkit_v0.4.4_u16_x86_64.tar.gz
tar -xzf modkit_v0.4.4_u16_x86_64.tar.gz
rm modkit_v0.4.4_u16_x86_64.tar.gz
echo 'export PATH="/opt/modkit/dist_modkit_v0.4.4_7cf558c:$PATH"' >> "$SINGULARITY_ENVIRONMENT"
# Install Dorado
cd /opt
mkdir dorado && cd dorado
wget https://cdn.oxfordnanoportal.com/software/analysis/dorado-1.0.1-linux-x64.tar.gz
tar -xzf dorado-1.0.1-linux-x64.tar.gz
rm dorado-1.0.1-linux-x64.tar.gz
echo 'export PATH="/opt/dorado/dorado-1.0.1-linux-x64/bin/:$PATH"' >> "$SINGULARITY_ENVIRONMENT"